After upgrading P.Lightening to 1.2.3, remains other incompatibilities with torch 1.8.0. A workaround until is sorted out all, is to stick with torch 1.7.1. #1869
Conversation
… pull down 1.8.0. Lightning-AI/pytorch-lightning#6168 Signed-off-by: Tibor Kiss <kiss.tibor@gmail.com>
tiborkiss
force-pushed
the
stick-torch-171
branch
from
d975d8e to
d3bcb90
Compare
There was a problem hiding this comment.
@tiborkiss thanks for the PR. However, we can't pin torch version exactly. PLT team is going to address 1.8 incompatibility soon, so giving a different range for PTL version could be a better solution here.
| @@ -2,7 +2,7 @@ numpy>=1.18.2 | |||
| onnx>=1.7.0 | |||
| pytorch-lightning>=1.1.0,<=1.1.5 | |||
| python-dateutil | |||
| torch | |||
There was a problem hiding this comment.
we can't pin torch to the exact version because it will force torch re-install if the user has slightly different version (e.g. 1.7.0) or inside NVIDIA's container (20.11-py3) which has version like (1.8.0a0+17f8c32 --- this is before upstream's 1.8)
There was a problem hiding this comment.
@okuchaiev thanks for the suggestion.
I tried to let torch as it was and just changed the range for pytorch-lightning>=1.2.0,<=1.2.2.
At this moment 1.2.2 is the latest and 1.2.0 seems to have some PyTorch 1.8 compatibility fixes.
I recreate the env from the scratch with ./reinstall.sh with the above PLT range changes, but the issue is still there. Cannot choose newer version from PLT.
Then I found somewhere a workaround like
torchtext>=0.5, <0.7 # TODO: temporary fix fix for compatibility
I downgraded torchtext to 0.7, then complained about _torchtext.so undefined symbol. Probably it will not be possible to downgrade just torchtest.
I have no other idea, then just for myself I come back to torch 1.7.1 and if somebody will install these days, may run in the same issue and do like myself.
There was a problem hiding this comment.
Now, pytorch-lightening 1.2.3 came out, which has the fix. I did a test. This PLT version incompatibility is fixed, but came out another. You can read #1868
tiborkiss
changed the title
|
thanks again @tiborkiss but we'll close this one for now because we can't pin torch version to the exact number like 1.7.1 We could add something like this right before upload to pypi though. |
… pull down 1.8.0. Lightning-AI/pytorch-lightning#6168
This diff temporarily solves the imported incompatibility reported in #1868